RFR: 8357600: Patch nmethod flushing message to include more details [v2]

[Cesar Soares Lucas]

On Fri, 23 May 2025 09:29:24 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move before lock & check logging
>
> A bit concerned about performance impact of this logging, especially since we are under `CodeCache_lock`. So I would suggest two improvements:
> 
> 1. Maybe move logging before acquiring `CodeCache_lock`? Not sure if it is safe for various `CodeCache::*` getters.
> 
> 2. Predicate the argument preparation/logging with:
> 
> ``` 
>   LogTarget(Debug, codecache) lt;
>   if (lt.is_enabled()) {
>     ...

@shipilev - I made changes following your suggestion. I moved the printing to before acquiring the lock and I also moved it to under a if checking if logging is enabled. I don't think these get/logging operation in particular need to be under a lock.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25402#issuecomment-2908154023