RFR: 8354383: C2: enable sinking of Type nodes out of loop [v2]

Roland Westrelin roland at openjdk.org
Mon May 26 08:36:39 UTC 2025


On Mon, 26 May 2025 07:24:43 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> `PhaseIdealLoop::try_sink_out_of_loop()` excludes `Type` nodes because
>> we ran into some issues where a `Type` node is sunk and then becomes
>> `top` but the control path of its uses doesn't become unreachable.
>> 
>> 8349479 should have fixed that so that exception no longer makes
>> sense.
>
> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review

> Maybe JDK-8319372 can now be reverted with JDK-8349479 in?

I think it would be safe but I'm unclear if it's worth doing or not.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25396#issuecomment-2908955452


More information about the hotspot-compiler-dev mailing list