RFR: 8357600: Patch nmethod flushing message to include more details [v2]
Aleksey Shipilev
shade at openjdk.org
Mon May 26 09:26:32 UTC 2025
On Sun, 25 May 2025 23:23:36 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:
>> Please review this patch for adding more details to nmethod flushing message. These details are particularly important when investigating interaction of JVMCI compiled code and code cache flushing heuristics.
>>
>> Tested on Linux x64 with JTREG tier1-3 using fastdebug and release builds.
>
> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>
> Move before lock & check logging
Not sure about calling `is_cold()` without a lock: looks like `_gc_epoch` counter is unsynchronized. Now that you predicated the bulk of the logging with logging checks, I think it is fine to grab `CodeCache_lock` before doing logging.
-------------
PR Review: https://git.openjdk.org/jdk/pull/25402#pullrequestreview-2867769019
More information about the hotspot-compiler-dev
mailing list