RFR: 8342692: C2: long counted loop/long range checks: don't create loop-nest for short running loops [v32]

[Emanuel Peter]

On Mon, 26 May 2025 18:54:56 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/castnode.cpp line 327:
>> 
>>> 325: }
>>> 326: 
>>> 327: bool CastLLNode::inner_loop_backedge(Node* proj) {
>> 
>> Suggestion:
>> 
>> bool CastLLNode::is_inner_loop_backedge(Node* proj) {
>> 
>> Optional. It would help me know that it is just a check. Otherwise, I wonder if we might "make" the inner loop backedge.
>
> Also: the only use is with input from `ProjNode* proj_out_or_null`, so why not require `ProjNode*` as input here?

It would make the pattern a bit more obvious. Otherwise, I might wonder why we are not checking if the proj is really a proj ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21630#discussion_r2107750540