RFR: 8357781: Deep recursion in PhaseCFG::set_next_call leads to stack overflow [v2]

Marc Chevalier mchevalier at openjdk.org
Tue May 27 09:01:17 UTC 2025


On Tue, 27 May 2025 08:47:56 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address comments
>
> test/hotspot/jtreg/compiler/c2/StackOverflowInSetNextCall.java line 30:
> 
>> 28:  * @summary Triggered a stack overflow in PhaseCFG::set_next_call. The graph is legitimately big (mostly deep and not wide)
>> 29:  *          which makes the old version of PhaseCFG::set_next_call crash.
>> 30:  *
> 
> Suggestion:
> 
>  * @summary Triggered a stack overflow in PhaseCFG::set_next_call due to a legitimately big (mostly deep and not wide) graph.
> 
> A bit more concise. Feel free to ignore.

I like it, it's more natural. I take it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25448#discussion_r2108636910


More information about the hotspot-compiler-dev mailing list