RFR: 8327963: C2: fix construction of memory graph around Initialize node to prevent incorrect execution if allocation is removed [v8]
Emanuel Peter
epeter at openjdk.org
Tue May 27 09:15:01 UTC 2025
On Tue, 27 May 2025 08:51:17 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review
>
> src/hotspot/share/opto/multnode.cpp line 51:
>
>> 49: auto find_proj = [which_proj, this](ProjNode* proj) {
>> 50: assert((Opcode() != Op_If && Opcode() != Op_RangeCheck) || proj->Opcode() == (which_proj ? Op_IfTrue : Op_IfFalse),
>> 51: "bad if #2");
>
> What do you mean by `bad if #2`? Can you write something more descriptive?
Ah, this was just copied. Would still be nice if it was improved ;)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24570#discussion_r2108622334
More information about the hotspot-compiler-dev
mailing list