RFR: 8356647: C2: Excessively strict assert in PhaseIdealLoop::do_unroll [v5]

[Christian Hagedorn]

On Tue, 27 May 2025 08:06:37 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> This assert seems a bit too tight. See the JBS issue to check the math: the bound of `trip_count` should be `<= 2^31`, while the current bound is ` < (julong)max_juint/2` = floor((2^32-1)/2) = (2^32-2) / 2 = 2^31-1.
>
> Marc Chevalier has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - +message in assert
>  - Move asserts around

Looks good, thanks for another iteration to improve the asserts and comments :-)

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25295#pullrequestreview-2871419116