RFR: 8357793: [PPC64] VM crashes with -XX:-UseSIGTRAP -XX:-ImplicitNullChecks [v2]

[Aleksey Shipilev]

On Wed, 28 May 2025 19:12:55 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> In case of -XX:-UseSIGTRAP -XX:-ImplicitNullChecks, we use the manually selected entry. (The same is true for -XX:-TrapBasedNullChecks -XX:-ImplicitNullChecks.)
>> We only need to use the correct NullPointerException entry in the compiler case.
>> 
>> With this patch, the manually selected entry matches the one selected by `PosixSignals::pd_hotspot_signal_handler`.
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix bastore without ImplicitNullChecks.

Sure. This is where my knowledge of PPC64 template interpreter ends. I guess this is still fine. My understanding: without implicit null checks, we have to do an explicit null check here.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25504#pullrequestreview-2876179378