RFR: 8316694: Implement relocation of nmethod within CodeCache [v19]
Evgeny Astigeevich
eastigeevich at openjdk.org
Fri May 30 16:58:00 UTC 2025
On Thu, 29 May 2025 23:18:43 GMT, Chad Rakoczy <duke at openjdk.org> wrote:
>> This PR introduces a new function to replace nmethods, addressing [JDK-8316694](https://bugs.openjdk.org/browse/JDK-8316694). It enables the creation of new nmethods from existing ones, allowing method relocation in the code heap and supporting [JDK-8328186](https://bugs.openjdk.org/browse/JDK-8328186).
>>
>> When an nmethod is replaced, a deep copy is performed. The corresponding Java method is updated to reference the new nmethod, while the old one is marked as unused. The garbage collector handles final cleanup and deallocation.
>>
>> This change does not modify existing code paths and therefore does not benefit much from existing tests. New tests were created and confirmed to pass on x64/aarch64 for slowdebug/fastdebug/release.
>
> Chad Rakoczy has updated the pull request incrementally with four additional commits since the last revision:
>
> - Add requires GC to tests
> - Add type for immutable_data_references
> - Fix incorrect destination set if no trampoline available
> - Update assert note in nmethod::clear_inline_caches
src/hotspot/share/code/nmethod.hpp line 28:
> 26: #define SHARE_CODE_NMETHOD_HPP
> 27:
> 28: #define IMMUTABLE_DATA_REFERENCES int
>From https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md#naming
> Type names and global names should use mixed-case with the first letter of each word capitalized (FooBar).
Instead of macro, use `using AaaBbbb = int;`.
You can move it inside `nmethod` declaration.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2116263311
More information about the hotspot-compiler-dev
mailing list