RFR: 8344942: Template-Based Testing Framework [v61]
    Emanuel Peter 
    epeter at openjdk.org
       
    Sat May 31 11:12:55 UTC 2025
    
    
  
On Fri, 30 May 2025 07:28:44 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch 'JDK-8344942-TemplateFramework-v3' of https://github.com/eme64/jdk into JDK-8344942-TemplateFramework-v3
>>  - move verification
>
> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 696:
> 
>> 694:      * rendering a template with {@code render(fuel)} (e.g. {@link ZeroArgs#render(float)}).
>> 695:      */
>> 696:     static final float DEFAULT_FUEL = 100.0f;
> 
> Fields defined in an interface are implicitly static and final
> Suggestion:
> 
>     float DEFAULT_FUEL = 100.0f;
@manuel suggested it.... but you are right, it is unnecessary!
https://www.tutorialspoint.com/interface-variables-are-static-and-final-by-default-in-java-why
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2117711864
    
    
More information about the hotspot-compiler-dev
mailing list