RFR: 8344942: Template-Based Testing Framework [v61]

[Emanuel Peter]

On Fri, 30 May 2025 07:12:05 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch 'JDK-8344942-TemplateFramework-v3' of https://github.com/eme64/jdk into JDK-8344942-TemplateFramework-v3
>>  - move verification
>
> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 324:
> 
>> 322:      * A {@link Template} with one argument.
>> 323:      *
>> 324:      * @param arg0Name The name of the (first) argument, used for hashtag replacements in the {@link Template}.
> 
> Nit and I'm okay with both: Should we name the first argument arg1 instead of arg0? Starting from zero might not be expected.

I renamed it to arg1, arg2, arg3, with types T1, T2, T3.

> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 341:
> 
>> 339:          *         {@link Template}.
>> 340:          */
>> 341:         public TemplateToken asToken(A a) {
> 
> Could also be named `valueArg0` which is more expressive and it's easier when working in an IDE:
> ![image](https://github.com/user-attachments/assets/ab44b841-2cd0-4c13-942c-0188f60b421c)
> 
> vs.
> 
> ![image](https://github.com/user-attachments/assets/63f06a73-1ecd-4592-bcad-adc637a4a096)
> 
> You could apply that change for the `render()` methods as well. Same for the two and three arg versions.

I renamed it to `arg1, arg2, arg3`, with types `T1, T2, T3`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2118050972
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2118050954