On Fri, 30 May 2025 07:48:27 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Merge branch 'JDK-8344942-TemplateFramework-v3' of https://github.com/eme64/jdk into JDK-8344942-TemplateFramework-v3
>> - move verification
>
> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestTutorial.java line 84:
>
>> 82: // Hint: if you want to see the generated source code, you can enable
>> 83: // printing of the source code that the CompileFramework receives,
>> 84: // with -DCompileFrameworkVerbose=true
>
> Maybe also add here that the printed output is not formatted and one might consider dumping it to an IDE or other tool to auto-format.
Nice idea! Extended it like this:
82 // Hint: if you want to see the generated source code, you can enable
83 // printing of the source code that the CompileFramework receives,
84 // with -DCompileFrameworkVerbose=true
+ 85 // The code may not be nicely formatted, especially regarding
+ 86 // indentation. You might consider dumping the generated code
+ 87 // into an IDE or other auto-formatting tool.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2118064440