RFR: 8370708: RISC-V: Add VerifyStackAtCalls [v5]

Feilong Jiang fjiang at openjdk.org
Tue Nov 4 04:14:04 UTC 2025


On Wed, 29 Oct 2025 09:48:16 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> Sanity tested and no issues with MAJIK t1 (with +VSC).
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into vsc
>  - Forgot fix format for VSAC
>  - Fixed format
>  - Label name
>  - li->mv, format, space
>  - Draft

src/hotspot/cpu/riscv/riscv.ad line 1187:

> 1185: }
> 1186: 
> 1187: constexpr uint64_t MAJIK_DWORD = 0xabbaabbaabbaabbaull;

Looking at `PhaseChaitin::dump_frame`, I found the hard-coded MAJIK word for x86. Should we add RISCV MAJIK DWORD here?
https://github.com/openjdk/jdk/blob/576f9694b092f2a11a6a4e5a82c2b0e12203bd9c/src/hotspot/share/opto/chaitin.cpp#L2409-L2411

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28005#discussion_r2488588626


More information about the hotspot-compiler-dev mailing list