RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v11]

Emanuel Peter epeter at openjdk.org
Wed Nov 5 12:08:18 UTC 2025


On Wed, 5 Nov 2025 12:01:49 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestTutorial.java line 720:
>> 
>>> 718:     //   variable from an outer Template. Luckily, the outer Templates have added their
>>> 719:     //   fields and variables, and you can now access them with "dataNames()". You can
>>> 720:     //   count them, get a list of them, or sample a random one.
>> 
>> (Sorry for also suggesting things for existing code, I just read through some of that to better understand the changes and found some things to improve)
>> 
>> Maybe for completeness we could add that any let() definition is only available in the current scope and nested scopes but do not cross a "template boundary"?
>
> Ok, but that does not really belong in this section, right? Here, we deal with the `DataName`s...

I'm adding a comment just before `generateWithHashtagAndDollarReplacements`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2494179923


More information about the hotspot-compiler-dev mailing list