RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v11]
Emanuel Peter
epeter at openjdk.org
Wed Nov 5 12:25:42 UTC 2025
On Wed, 5 Nov 2025 09:21:14 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> small adjustments after call with Roberto and Christian
>
> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestTutorial.java line 860:
>
>> 858: // Define a local variable.
>> 859: // Note: it is very important that we use a "transparentScope" for the template here,
>> 860: // so that the DataName can escape to outer scopes.
>
> Might be obvious but you could add that it does not mean it's available for the entire outer scope but only for everything that follows this DataName definition/insertion point of this template.
I'm adding a comment there. Maybe I should also add a comment in the javadocs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2494241690
More information about the hotspot-compiler-dev
mailing list