RFR: 8370939: C2: SIGSEGV in SafePointNode::verify_input when processing MH call from Compile::process_late_inline_calls_no_inline() [v4]

[Roland Westrelin]

On Tue, 4 Nov 2025 10:24:48 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> I think that would make sense. But the only use of that counter (excluding asserts) seems to be:
>> 
>> https://github.com/openjdk/jdk/blob/ef464d69399e50aee126a4756fe9a9a19e44d3c4/src/hotspot/share/opto/compile.cpp#L829
>> 
>> Maybe, then, it's simpler to not bother with maintaining an accurate count. See new commits.
>> 
>> 8352963 added a new call `inc_number_of_mh_late_inlines()` that I remove here because I don't think it's needed. I had a look at the PR for that one and I don't see it discussed. @dafedafe do you remember why you added it?
>
> AFAIR at some point I was getting the same assert failure `assert(_number_of_mh_late_inlines > 0)` and  noticed that we were re-registering method handles for late inlining without incrementing the counter.

Do you remember what tests that was with?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28088#discussion_r2494362354