RFR: 8370315: [IR-Framework] Allow scenarios to be run in parallel [v3]
Damon Fenacci
dfenacci at openjdk.org
Wed Nov 5 16:02:41 UTC 2025
On Mon, 3 Nov 2025 15:44:34 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 762:
>>
>>> 760: outcome = new Outcome(scenario, null, null);
>>> 761: } catch (TestFormatException e) {
>>> 762: outcome = new Outcome(scenario, e, null);
>>
>> Why do you collect the format exceptions here and only throw them later? Is a fail-fast not possible?
>
> Actually it is (maybe a bit more tricky but possible). Changing this...
Trying to keep it simple, I've changed it so that other threads stop immediately if one has already thrown a `TestFormatException`. I also added `startParallel` tests to `TestBadFormat.java` to check for `TestFormatException`s with parallel scenarios. That exposed another issue with `TestFormat`: the list of failures there was static and could be filled by all threads concurrently. To keep things simple I turned it into a thread local field.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28065#discussion_r2495166808
More information about the hotspot-compiler-dev
mailing list