RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v14]
Christian Hagedorn
chagedorn at openjdk.org
Thu Nov 6 10:17:46 UTC 2025
On Thu, 6 Nov 2025 10:09:29 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - for Christian
>> - Apply suggestions from code review
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> test/hotspot/jtreg/compiler/lib/template_framework/CodeFrame.java line 50:
>
>> 48: * <p>
>> 49: * Note, that {@link CodeFrame}s and {@link TemplateFrame}s often go together, but can also
>> 50: * diverge.
>
> Can you give an example here where/when this is the case? If there are not many variants, it might be worth to list them here.
It might also help to show a simple visual/sketch example how template frames, code frames and scopes work together. I think it's a little tricky at first to grasp how they interact.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2498344312
More information about the hotspot-compiler-dev
mailing list