RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v14]

Emanuel Peter epeter at openjdk.org
Thu Nov 6 12:48:18 UTC 2025


On Thu, 6 Nov 2025 08:47:23 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - for Christian
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> test/hotspot/jtreg/compiler/lib/template_framework/Renderer.java line 237:
> 
>> 235:         // If the ScopeToken is transparent to Names, then the Template is transparent to names.
>> 236:         ScopeToken st = templateToken.instantiate();
>> 237:         renderScopeToken(st, () -> {});
> 
> Just a suggestion: You seem to use `() -> {}` quite often when calling `renderScopeToken()`. Might be worth to overload it and provide one `renderScopeToken()` version with just a `ScopeToken`.

Nice idea :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2498823367


More information about the hotspot-compiler-dev mailing list