RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v14]

[Emanuel Peter]

On Thu, 6 Nov 2025 09:26:17 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - for Christian
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> test/hotspot/jtreg/compiler/lib/template_framework/TemplateFrame.java line 30:
> 
>> 28: 
>> 29: /**
>> 30:  * The {@link TemplateFrame} is the frame for a {@link Template} and its inner
> 
> unique?
> 
> Suggestion:
> 
>  * The {@link TemplateFrame} is the frame for a unique {@link Template} and its inner

I adjusted it a little different. Because it is not per Template, but per rendering of a template. But the follwing sentences also back that up. I hope it is clear now.

> test/hotspot/jtreg/compiler/lib/template_framework/TemplateFrame.java line 34:
> 
>> 32:  * {@link #id} used to deconflict names using {@link Template#$}. It also has a set of hashtag
>> 33:  * replacements, which combine the key-value pairs from the template argument and the
>> 34:  * {@link Template#let} definitions. Inner scopes of a {@link Template} have access to
> 
> `Inner scopes of a {@link Template} [...]`
> 
> Should be obvious but since it's a class comment you could add something here that we only mean scopes that are not template themselves.

I don't really know how to say it better than I am already. Do you have a suggestion?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2498894986
PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2498903894