RFR: 8369646: Detection of redundant conversion patterns in add_users_of_use_to_worklist is too restrictive [v4]

[Benoît Maillard]

On Tue, 4 Nov 2025 08:54:18 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Yes, in some cases `add_users_of_use_to_worklist` is called with the node about to be replaced as argument `n`. The point is that we might replace `n` with a node that already has other uses, and we only want to notify the uses for which there is a potential change.
>> But this is in no way specific to this one optimization, so I think adding something here would cause more confusion than anything else. Perhaps we should update the description of `add_users_of_use_to_worklist` then?
>
> Right, this is not specific to this optimization here. Why not add something at the level of `add_users_of_use_to_worklist`.

Sorry for the delay, I ended up adding comments to the definition of both `add_users_to_worklist` and `add_users_of_use_to_worklist`. I think this might help avoid some confusion in the future.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27900#discussion_r2499336288