RFR: 8366990: C2: Compilation hits the memory limit when verifying loop opts in Split-If code [v9]

Benoît Maillard bmaillard at openjdk.org
Thu Nov 6 16:27:43 UTC 2025


On Thu, 6 Nov 2025 15:58:24 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply suggestions from code review
>>   
>>   Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> src/hotspot/share/ci/ciInstanceKlass.cpp line 435:
> 
>> 433: 
>> 434: // This is essentially a shortcut for:
>> 435: //   get_field_by_offset(field_offset, is_static)->layout_type()
> 
> Suggestion:
> 
> // get_field_by_offset(field_offset, is_static)->layout_type()
> 
> 
> Did you actually want the indentation?

It was on purpose yes, I think it was to avoid making it look like code that was commented out

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27731#discussion_r2499762600


More information about the hotspot-compiler-dev mailing list