RFR: 8370196: C2: Improve (U)MulHiLNode::MulHiValue [v2]

[Zihao Lin]

On Mon, 10 Nov 2025 10:55:23 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Zihao Lin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/share/opto/mulnode.cpp
>>   
>>   Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
>
> src/hotspot/share/opto/mulnode.cpp line 622:
> 
>> 620:   const TypeLong *longType1 = t1->is_long();
>> 621:   const TypeLong *longType2 = t2->is_long();
>> 622:   if(longType1 && longType2 && longType1->is_con() && longType2->is_con()){
> 
> Suggestion:
> 
>   if(longType1 != nullptr && longType2 != nullptr && longType1->is_con() && longType2->is_con()){
> 
> I know, it seems a bit fussy, but that's the way we do it.

Got it, thank you

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28097#discussion_r2516830796