RFR: 8341039: compiler/cha/TypeProfileFinalMethod.java fails with assertEquals expected: 0 but was: 2

[Roberto Castañeda Lozano]

On Fri, 7 Nov 2025 16:25:59 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

> The test `compiler/cha/TypeProfileFinalMethod.java` exercises a specific compilation pattern and easily breaks by setting various VM flags (e.g., `-Xcomp`).
> 
> ### Changeset
> 
> - Make the test flagless.
> - Ensure the test only compiles the intended methods.
> - Fix problems with compiler directives used in the test (incorrect signatures and some directives getting unintentionally shadowed by other directives).
> - Force C2 inlining of a method which the test author likely intended to always be inlined (based on source code comments in the test).
> - Switch argument order in `assertEquals` to make error message correct.
> 
> Note for reviewers: A more fundamental rewrite of the test is beyond the scope of this changeset. The objective here is simply to ensure the test runs only in contexts intended by the test author.
> 
> ### Testing
> 
> - [GitHub Actions](https://github.com/dlunde/jdk/actions/runs/18972906513)
> - `tier1` and HotSpot parts of `tier2` and `tier3` (and additional Oracle-internal testing) on Windows x64, Linux x64, Linux aarch64, macOS x64, and macOS aarch64.
> - Stress testing of the specific test on Windows x64, Linux x64, Linux aarch64, macOS x64, and macOS aarch64.

Thanks for resurrecting this test, Daniel! The changes look good, I just have a minor suggestion (readding a useful comment that was removed in the changeset).

test/hotspot/jtreg/compiler/cha/TypeProfileFinalMethod.java line 104:

> 102:                 // Make sure to inline test1 in C2 compilation
> 103:                 "c2: { inline:[\"+" + Launcher.class.getName()+"::test1\"]," +
> 104:                 "      PrintInlining:true }" +

Suggestion:

                // Print the inline tree for checking
                "      PrintInlining:true }" +

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28200#pullrequestreview-3452390259
PR Review Comment: https://git.openjdk.org/jdk/pull/28200#discussion_r2517517847