RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v26]

Emanuel Peter epeter at openjdk.org
Wed Nov 12 15:30:07 UTC 2025


On Wed, 12 Nov 2025 12:49:52 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add missing comma from suggestion application
>
> test/hotspot/jtreg/compiler/lib/template_framework/TemplateFrame.java line 60:
> 
>> 58:  * The {@link #parent} relationship provides a trace for the use chain of templates and
>> 59:  * their inner scopes. The {@link #fuel} is reduced over this chain to give a heuristic
>> 60:  * on how much time is spent on the code from the template corresponding to the frame,
> 
> "time" sounds misleading. What about: [...] on how many times we already nested the template corresponding to the frame recursively [...]?

Hmm, well the idea is really to limit runtime once we run the generated code... But that correlates to the nesting depth and the iteration count of loops etc.

I now wrote this:

   61  * The {@link #parent} relationship provides a trace for the use chain of templates and
   62  * their inner scopes. The {@link #fuel} is reduced over this chain to give a heuristic
~  63  * on how deeply nested the code is at a given point, correlating to the runtime that
~  64  * would be spent if the code was executed. The idea is that once the fuel is depleated,
+  65  * we do not want to nest more deaply, so that there is a reasonable chance that the
+  66  * execution of the generated code can terminate.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2518758484


More information about the hotspot-compiler-dev mailing list