RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v26]

[Emanuel Peter]

On Wed, 12 Nov 2025 12:35:01 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add missing comma from suggestion application
>
> Thanks for the update Emanuel! These look good. I will now have a look at the rest of your code 👍

@chhagedorn Thanks for spending all the time on this, and the many great suggestions :)
I applied most of them directly, and modified some of the documentation based on your suggestion, but trying to make things even more precise.

Do you want to have another quick look here, or should we ask @robcasloz to have a look next?

> test/hotspot/jtreg/compiler/lib/template_framework/Renderer.java line 346:
> 
>> 344:                 currentCodeFrame.addName(name);
>> 345:             }
>> 346:             case ScopeToken st -> {
> 
> For this and below, can you use full names (i.e. `scopeToken` etc.)? This makes it a little easier to read instead of the abbreviations.

Ok, enabled full verbosity mode ;)

> test/hotspot/jtreg/compiler/lib/template_framework/StructuralName.java line 289:
> 
>> 287:         }
>> 288:     }
>> 289: }
> 
> Feels like we have a lot of duplication in `DataName` and `StructuralName`. But I'm not sure if/how we could share it somehow. Anyhow, not something for today.

Maybe it could be somehow smartly collapsed. Maybe using some smart way with Generics. But I could not find a good solution yet. Right, it could be tried in a later RFE.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27255#issuecomment-3522585069
PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2518796764
PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2518805319