RFR: 8369002: Extract the loop->is_member(get_loop(get_ctrl(node))) pattern in a new function [v2]

Anton Seoane Ampudia aseoane at openjdk.org
Thu Nov 13 10:36:28 UTC 2025


On Wed, 12 Nov 2025 17:03:08 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Anton Seoane Ampudia has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments: update types
>
> src/hotspot/share/opto/loopnode.hpp line 1379:
> 
>> 1377: 
>> 1378:   // Return a post-walked LoopNode
>> 1379:   IdealLoopTree *get_loop(const Node* n) const {
> 
> Nit suggestion (where is my "Add suggestion" button?): `IdealLoopTree *get_loop` -> `IdealLoopTree* get_loop`.

Oh, absolutely! Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28259#discussion_r2522841575


More information about the hotspot-compiler-dev mailing list