RFR: 8369002: Extract the loop->is_member(get_loop(get_ctrl(node))) pattern in a new function [v3]

[Benoît Maillard]

On Thu, 13 Nov 2025 10:36:25 GMT, Anton Seoane Ampudia <aseoane at openjdk.org> wrote:

>> This PR adds a "shorthand" for the common `loop->is_member(get_loop(get_ctrl(node)))` pattern in loop optimizations.
>> 
>> In PhaseIdealLoop, there is already an `is_member` function that checks if a node is a (nested) member of an IdealLoopTree. In a similar fashion, this changeset adds a `ctrl_is_member` that aims to simplify the common pattern of:
>> 
>> Node* node_ctrl = get_ctrl(node);
>> if (loop->is_member(get_loop(node))) { ... }
>> 
>> 
>> This hopes to provide a bit more readability and code conciseness in such a common operation.
>> 
>> **Testing:** passes tiers 1-3
>
> Anton Seoane Ampudia has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments: nit

Marked as reviewed by bmaillard (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28259#pullrequestreview-3459822128