RFR: 8293484: AArch64: TestUseSHA512IntrinsicsOptionOnSupportedCPU.java fails on CPU with SHA512 feature support [v2]
Hao Sun
haosun at openjdk.org
Fri Nov 14 11:08:10 UTC 2025
On Fri, 14 Nov 2025 07:16:02 GMT, Ramkumar Sunderbabu <rsunderbabu at openjdk.org> wrote:
>> We have a host of tests under test/hotspot/jtreg/compiler/intrinsics/sha which checks if the SHA intrinsics flags' enable/disable setting is in sync with CPU support in the underlying platform. There might be situations where the intrinsics might not be enabled despite the hardware supporting the relevant instructions. For example, there might be reliability issues or performance issues. In such situations, the tests will fail.
>>
>> Till now, the approach has been to exclude the platforms where the support is yet to be provided and remove the exclusion after. This necessitates additional work on the test front.
>>
>> A more compact design would be make predicate probes to rely on intrinsics availability in the platform as opposed to hardware support availability. The migration to intrinsics availability would especially help update releases where feature backport might not be complete.
>>
>> PS: This fix can/should be propagated to other such tests as well. Once this PR gets approval, I will work on similar tests.
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one additional commit since the last revision:
>
> removing requires condition
Yes, I think the requires condition can be removed safely because we have a stronger check now. Thanks for your update.
-------------
Marked as reviewed by haosun (Committer).
PR Review: https://git.openjdk.org/jdk/pull/28053#pullrequestreview-3464415982
More information about the hotspot-compiler-dev
mailing list