Integrated: 8371804: C2: Tighten up LoadNode::Value comments after JDK-8346184
Aleksey Shipilev
shade at openjdk.org
Fri Nov 14 15:33:58 UTC 2025
On Thu, 13 Nov 2025 14:30:10 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> This confused me quite a bit in [JDK-8371581](https://bugs.openjdk.org/browse/JDK-8371581) investigations.
>
> With [JDK-8346184](https://bugs.openjdk.org/browse/JDK-8346184), we have moved the block in `LoadNode::Value` that produced bottom values for the block that "If we are loading from a freshly-allocated object, produce a zero, if the load is provably beyond the header of the object." This comment is misleading, and really relates to the old place, which actually returns zeroes.
>
> It would be better to clean this up to avoid further confusion. There should be no semantic change, only the cleanup.
>
> Additional testing:
> - [x] GHA
> - [x] Linux AArch64 server fastdebug, `tier1`
This pull request has now been integrated.
Changeset: 10f262a6
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/10f262a6ad9a6e89cd79409c5e1a3f7efda76928
Stats: 15 lines in 1 file changed: 3 ins; 4 del; 8 mod
8371804: C2: Tighten up LoadNode::Value comments after JDK-8346184
Reviewed-by: kvn, vlivanov
-------------
PR: https://git.openjdk.org/jdk/pull/28296
More information about the hotspot-compiler-dev
mailing list