RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v29]

[Roberto Castañeda Lozano]

On Thu, 13 Nov 2025 07:43:53 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   inflate abreviations to full names
>
> test/hotspot/jtreg/compiler/lib/template_framework/TemplateFrame.java line 53:
> 
>> 51:  * has such a set of hashtag replacements, and implicitly provides access to the
>> 52:  * hashtag replacements of the outer {@link TemplateFrame}s, up to the outermost
>> 53:  * of the current {@link Template}. If a hashtag replacemnt is added in a scope,
> 
> Suggestion:
> 
>  * of the current {@link Template}. If a hashtag replacement is added in a scope,

@eme64 please apply this suggestion.

> test/hotspot/jtreg/compiler/lib/template_framework/TemplateFrame.java line 54:
> 
>> 52:  * hashtag replacements of the outer {@link TemplateFrame}s, up to the outermost
>> 53:  * of the current {@link Template}. If a hashtag replacemnt is added in a scope,
>> 54:  * we have to find traverse to outer scopes until we find one that is not transparent
> 
> Suggestion:
> 
>  * we have to traverse to outer scopes until we find one that is not transparent

@eme64 please apply this suggestion.

> test/hotspot/jtreg/compiler/lib/template_framework/TemplateFrame.java line 65:
> 
>> 63:  * on how deeply nested the code is at a given point, correlating to the runtime that
>> 64:  * would be spent if the code was executed. The idea is that once the fuel is depleated,
>> 65:  * we do not want to nest more deaply, so that there is a reasonable chance that the
> 
> Suggestion:
> 
>  * we do not want to nest more deeply, so that there is a reasonable chance that the

@eme64 please apply this suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2534468193
PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2534468724
PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2534469828