RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v30]

Emanuel Peter epeter at openjdk.org
Tue Nov 18 08:16:56 UTC 2025


On Mon, 17 Nov 2025 14:52:20 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   document hashtag locality for Roberto
>
> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 624:
> 
>> 622:      * hashtag-replacements and {@link #setFuelCost} are always implicitly
>> 623:      * non-transparent (i.e. non-escaping) for hashtag-replacements and
>> 624:      * {@link #setFuelCost} (e.g. a {@link #let} will not escape the template
> 
> I could not parse the following sentence: "hashtag-replacements and setFuelCost are always implicitly non-transparent (i.e. non-escaping) for hashtag-replacements and setFuelCost", could you explain it (or rewrite it in a clearer way)?

Right, I am repeating the `hashtag-replacements and setFuelCost` part. Fixed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2536779770


More information about the hotspot-compiler-dev mailing list