RFR: 8365732: RISC-V: implement AES CTR intrinsics [v26]

Hamlin Li mli at openjdk.org
Wed Nov 19 09:59:30 UTC 2025


On Wed, 19 Nov 2025 04:56:10 GMT, Anjian Wen <wenanjian at openjdk.org> wrote:

> > Some more comments and questions.
> 
> Thanks for the careful reviews! I will check the comments and reply one by one later


Thanks! Overall looks good, I'll have another by this weekend. Thanks for your patience!

>> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 2670:
>> 
>>> 2668:     __ enter();
>>> 2669: 
>>> 2670:     Label L_EXIT;
>> 
>> Suggestion:
>> 
>>     Label L_exit;
>
> I try to make it different from the L_exit in counterMode_AESCrypt function, should I change this to L_exit2 or L_exit_main?

The labels are in different method, should be fine with same name? I'm not quite sure.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25281#issuecomment-3551824410
PR Review Comment: https://git.openjdk.org/jdk/pull/25281#discussion_r2541309073


More information about the hotspot-compiler-dev mailing list