RFR: 8365732: RISC-V: implement AES CTR intrinsics [v26]
Anjian Wen
wenanjian at openjdk.org
Thu Nov 20 02:54:17 UTC 2025
On Wed, 19 Nov 2025 09:50:05 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> key length could be only {11, 13, 15} * 4 = {44, 52, 60},I notice that x86 and aarch64 use directly 52,I think add some more comment will be enough?
>
> Can you add some comments in other existing code with magic 52 if they mean the same thing? Thanks!
sure,I have already added comments to the identical parts.
>> it's a return value saved to x10, it seems necessary according to aarch64 and x86, aarch64 used r0 to save it and x86 used rax
>
> There is a `mv` before exit of `generate_counterMode_AESCrypt`, is this one still necessary?
Yes, about the `mv` before `generate_counterMode_AESCrypt`, it is for a different branch when input_len is zero at the first time. For the purpose to avoid additional jump, each code exit from `counterMode_AESCrypt` is a Independent exit, so I think we need to keep this `mv` here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25281#discussion_r2544162600
PR Review Comment: https://git.openjdk.org/jdk/pull/25281#discussion_r2544163484
More information about the hotspot-compiler-dev
mailing list