RFR: 8370489: Some compiler tests miss the @key randomness

Christian Hagedorn chagedorn at openjdk.org
Mon Nov 24 07:26:23 UTC 2025


On Fri, 21 Nov 2025 23:31:16 GMT, Saranya Natarajan <snatarajan at openjdk.org> wrote:

> **Issue:** Some compiler tests uses randomization but does not have `@key randomness` in the jtreg header.
> 
> **Fix:** The list of test cases that did not have  `@key randomness` were listed using  `grep -l "getRandomInstance" -r test/hotspot/jtreg/compiler/ | xargs grep -L "randomness"`. This PR adds `@key randomness` to these tests. 
> 
> **Note:** The following tests that are still listed with  `grep -l "getRandomInstance" -r test/hotspot/jtreg/compiler/ | xargs grep -L "randomness"` after this PR are confirmed to be helper or support file for actual test.
> _test/hotspot/jtreg/compiler/codegen/aes/TestAESBase.java
> test/hotspot/jtreg/compiler/compilercontrol/jcmd/StressAddJcmdBase.java
> test/hotspot/jtreg/compiler/compilercontrol/parser/HugeDirectiveUtil.java
> test/hotspot/jtreg/compiler/compilercontrol/share/scenario/CommandGenerator.java
> test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java
> test/hotspot/jtreg/compiler/lib/ir_framework/test/ArgumentValue.java
> test/hotspot/jtreg/compiler/lib/ir_framework/AbstractInfo.java
> test/hotspot/jtreg/compiler/lib/ir_framework/CompLevel.java
> test/hotspot/jtreg/compiler/lib/generators/Generators.java
> test/hotspot/jtreg/compiler/lib/template_framework/library/PrimitiveType.java
> test/hotspot/jtreg/compiler/lib/template_framework/library/Expression.java
> test/hotspot/jtreg/compiler/lib/template_framework/NameSet.java
> test/hotspot/jtreg/compiler/intrinsics/mathexact/Verify.java
> test/hotspot/jtreg/compiler/intrinsics/bmi/BMITestRunner.java
> test/hotspot/jtreg/compiler/intrinsics/unsafe/ByteBufferTest.java
> test/hotspot/jtreg/compiler/arraycopy/stress/StressBooleanArrayCopy.java
> test/hotspot/jtreg/compiler/arraycopy/stress/StressIntArrayCopy.java
> test/hotspot/jtreg/compiler/arraycopy/stress/StressLongArrayCopy.java
> test/hotspot/jtreg/compiler/arraycopy/stress/StressCharArrayCopy.java
> test/hotspot/jtreg/compiler/arraycopy/stress/StressObjectArrayCopy.java
> test/hotspot/jtreg/compiler/arraycopy/stress/StressByteArrayCopy.java
> test/hotspot/jtreg/compiler/arraycopy/stress/StressFloatArrayCopy.java
> test/hotspot/jtreg/compiler/arraycopy/stress/StressShortArrayCopy.java
> test/hotspot/jtreg/compiler/arraycopy/stress/StressDoubleArrayCopy.java
> test/hotspot/jtreg/compiler/codecache/cli/codeheapsize/JVMStartupRunner.java
> test/hotspot/jtreg/compiler/vectorapi/reshape/utils/VectorReshapeHelper.java
> test/hotspot/jtreg/compiler/jvmci/compilerToVM/DummyClass.java_

Looks good and trivial, thanks for cleaning these up!

test/hotspot/jtreg/compiler/vectorization/TestVectorZeroCount.java line 25:

> 23: 
> 24: package compiler.vectorization;
> 25: import java.util.Random;

Suggestion:

package compiler.vectorization;

import java.util.Random;

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28463#pullrequestreview-3498644956
PR Review Comment: https://git.openjdk.org/jdk/pull/28463#discussion_r2554894805


More information about the hotspot-compiler-dev mailing list