RFR: 8357258: x86: Improve receiver type profiling reliability [v3]
Aleksey Shipilev
shade at openjdk.org
Wed Nov 26 10:41:03 UTC 2025
On Fri, 21 Nov 2025 19:25:08 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>>
>> - Merge branch 'master' into JDK-8357258-x86-c1-optimize-virt-calls
>> - Merge branch 'master' into JDK-8357258-x86-c1-optimize-virt-calls
>> - Drop atomic counters
>> - Initial version
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 4818:
>
>> 4816: addptr(offset, receiver_step);
>> 4817: cmpptr(offset, end_receiver_offset);
>> 4818: jccb(Assembler::notEqual, L_loop);
>
> Fix indention since these instructions also in the loop.
I prefer to keep these at this indentation level: this is loop infrastructure. Pretty much like I would write the post-condition:
do {
...
} while ((offset += receiver_step) != end_receiver_offset);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25305#discussion_r2564461790
More information about the hotspot-compiler-dev
mailing list