RFR: 8372461: [IR Framework] Multiple test failures after JDK-8371789

[Emanuel Peter]

On Tue, 25 Nov 2025 16:51:39 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> [JDK-8371789](https://bugs.openjdk.org/browse/JDK-8371789) improved the C2 type dumps but unfortunately also broke some IR Framework internal tests and some regexes:
> 
> - `TestIRMatching.java`: Forgot to update old reference to "precise". Replaced with "Constant".
> - `IRNode.CHECKCAST_ARRAY*`: Forgot to update old reference to "precise". Replaced with `Constant` and added `aryklassptr`.
> - Some clean-up to `LOAD_STORE_PREFIX` was incorrect since we no longer match various combinations tested with `TestIRMatching.java` and `TestPhaseIRMatching.java`. For example:
> https://github.com/openjdk/jdk/blob/67ef81eb78b28e5dcdf91785b476dfd0858cbd16/test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPhaseIRMatching.java#L766-L783
> I reverted the no-longer matching part of the regex back to what we had before JDK-8371789.
> 
> #### Testing
> - [X] Tier1
> - [X] Tier5 with IR framework internal tests only
> - [ ] Additionally testing `TestIRMatching.java` and `TestPhaseIRMatching.java` on arm, aarch64, ppc64le, ppc64be s390, and riscv64 (thanks to  @mhaessig for taking care of that!)
> 
> Thanks,
> Christian

I suppose the issue that caused the regression was not properly tested?

Anyway: thanks for fixing is 😊

-------------

Marked as reviewed by epeter (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28495#pullrequestreview-3511395470