RFR: 8372461: [IR Framework] Multiple test failures after JDK-8371789 [v2]
Christian Hagedorn
chagedorn at openjdk.org
Thu Nov 27 14:19:13 UTC 2025
> [JDK-8371789](https://bugs.openjdk.org/browse/JDK-8371789) improved the C2 type dumps but unfortunately also broke some IR Framework internal tests and some regexes:
>
> - `TestIRMatching.java`: Forgot to update old reference to "precise". Replaced with "Constant".
> - `IRNode.CHECKCAST_ARRAY*`: Forgot to update old reference to "precise". Replaced with `Constant` and added `aryklassptr`.
> - Some clean-up to `LOAD_STORE_PREFIX` was incorrect since we no longer match various combinations tested with `TestIRMatching.java` and `TestPhaseIRMatching.java`. For example:
> https://github.com/openjdk/jdk/blob/67ef81eb78b28e5dcdf91785b476dfd0858cbd16/test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestPhaseIRMatching.java#L766-L783
> I reverted the no-longer matching part of the regex back to what we had before JDK-8371789.
>
> #### Testing
> - [X] Tier1
> - [X] Tier5 with IR framework internal tests only
> - [ ] Failing IR framework internal tests on all platforms
>
> Thanks,
> Christian
Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
Fix wrong regex
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28495/files
- new: https://git.openjdk.org/jdk/pull/28495/files/b7fcd4f1..a8f26f29
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28495&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28495&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/28495.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28495/head:pull/28495
PR: https://git.openjdk.org/jdk/pull/28495
More information about the hotspot-compiler-dev
mailing list