RFR: 8364766: C2: Improve Value() of DivI and DivL for non-constant inputs [v11]
Manuel Hässig
mhaessig at openjdk.org
Fri Nov 28 10:24:56 UTC 2025
On Fri, 14 Nov 2025 21:50:27 GMT, Tobias Hotz <duke at openjdk.org> wrote:
>> This PR improves the value of interger division nodes.
>> Currently, we only emit a good type if either input is constant. But we can also cover the generic case. It does that by finding the four corners of the division. This is guranteed to find the extrema that we can use for min/max. Some special logic is required for MIN_INT / -1, though, as this is a special case
>> We also need some special logic to handle ranges that cross zero, but in this case, we just need to check for the negative and positive range once.
>> This also cleans up and unifies the code paths for DivINode and DivLNode.
>> I've added some tests to validate the optimization. Without the changes, some of these tests fail.
>
> Tobias Hotz has updated the pull request incrementally with one additional commit since the last revision:
>
> Simplify test, add temporary @IR rule for testLongRange and improve comments
Sorry for dropping the ball. The changes look good. I'll start another round of testing.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26143#pullrequestreview-3518341196
More information about the hotspot-compiler-dev
mailing list