RFR: 8353290: C2: Refactor PhaseIdealLoop::is_counted_loop() [v3]

Kangcheng Xu kxu at openjdk.org
Wed Oct 1 05:00:50 UTC 2025


On Thu, 19 Jun 2025 16:30:51 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Resolved conflict with [JDK-8357951](https://bugs.openjdk.org/browse/JDK-8357951). @chhagedorn I'd appreciate a re-review. Thank you so much!
>
> Thanks @tabjy for coming back with an update and pinging me again! Sorry, I completely missed it the first time. I will be on vacation starting tomorrow for two weeks but I'm happy to take another look when I'm back :-)

@chhagedorn Thanks for reviewing. Sorry this took longer than I'd like. I've made the following changes:

- fixed typos
- better naming and pattern (e.g., `_` prefixes, unneeded code/brackets/spaces)
- changed `strcut` to `class` 
- hide fields behind accessor methods
- extracted relevant code into classes methods where makes sense
- resolved conflict

Thank you!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24458#issuecomment-3354745863


More information about the hotspot-compiler-dev mailing list