RFR: 8353290: C2: Refactor PhaseIdealLoop::is_counted_loop() [v12]

[Kangcheng Xu]

On Wed, 1 Oct 2025 07:45:26 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 29 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into counted-loop-refactor
>>    
>>    # Conflicts:
>>    #	src/hotspot/share/opto/loopnode.cpp
>>  - futher refactor counted loop conversion
>>  - WIP: remove unused #include
>>  - WIP: refactor structs to classes
>>  - WIP: removed dead code, renamed fields and signatures
>>  - Merge branch 'openjdk:master' into counted-loop-refactor
>>  - Merge remote-tracking branch 'origin/master' into counted-loop-refactor
>>    
>>    # Conflicts:
>>    #	src/hotspot/share/opto/loopnode.cpp
>>    #	src/hotspot/share/opto/loopnode.hpp
>>  - Merge branch 'master' into counted-loop-refactor
>>    
>>    # Conflicts:
>>    #	src/hotspot/share/opto/loopnode.cpp
>>    #	src/hotspot/share/opto/loopnode.hpp
>>    #	src/hotspot/share/opto/loopopts.cpp
>>  - Merge remote-tracking branch 'origin/master' into counted-loop-refactor
>>  - further refactor is_counted_loop() by extracting functions
>>  - ... and 19 more: https://git.openjdk.org/jdk/compare/0366d882...b1d27675
>
> src/hotspot/share/opto/loopopts.cpp line 1695:
> 
>> 1693:       !n->is_OpaqueInitializedAssertionPredicate() &&
>> 1694:       !n->is_OpaqueTemplateAssertionPredicate() &&
>> 1695:       !n->is_Type()) {
> 
> This change seems unrelated. Bad merge?

Nice catch! Yes it looks like a bad merge. Sorry! Changes from 8354383(https://github.com/openjdk/jdk/commit/a2f99fd88bd03337e1ba73b413ffe4e39f3584cf) is re-added.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24458#discussion_r2394994618