RFR: 8355574: Fatal error in abort_verify_int_in_range due to Invalid CastII [v5]

Quan Anh Mai qamai at openjdk.org
Fri Oct 3 12:27:04 UTC 2025


> Hi,
> 
> The issue here is that the `CastLLNode` is created before the actual check that ensures the range of the input. This patch fixes it by moving the creation to the correct place, which is under `inline_block`. I also noticed that the code there seems incorrect and confusing. `ArrayCopyNode::get_partial_inline_vector_lane_count` takes the length of the array, not the size in bytes. If you look into the method it will multiply `const_len` with `type2aelementbytes(bt)` to get the size in bytes of the array. In the runtime test, we compare `length << log2(type2bytes(bt))` with `ArrayOperationPartialInlineSize`. This seems confusing, why don't we just compare `length` with `ArrayOperationPartialInlineSize / type2bytes(bt)`, it also unifies the test with the actual cast.
> 
> Please take a look and leave your reviews, thanks a lot.

Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:

 - Merge branch 'master' into misplacedcastll
 - fix comment
 - fix comment
 - fix
 - fix issues
 - misplaced CastLL

-------------

Changes: https://git.openjdk.org/jdk/pull/25284/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25284&range=04
  Stats: 54 lines in 5 files changed: 8 ins; 14 del; 32 mod
  Patch: https://git.openjdk.org/jdk/pull/25284.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25284/head:pull/25284

PR: https://git.openjdk.org/jdk/pull/25284


More information about the hotspot-compiler-dev mailing list