RFR: 8369423: Reduce execution time of testlibrary_tests/ir_framework/tests/TestDFlags.java

Damon Fenacci dfenacci at openjdk.org
Wed Oct 8 15:21:56 UTC 2025


On Wed, 8 Oct 2025 11:30:43 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> The test `testlibrary_tests/ir_framework/tests/TestDFlags.java` runs 11 separate IR framework runs by enabling only a single property/D flag in each run. This seems like a waste of resources for just a sanity run (we don't do any additional verification). Moreover, some newer property flags are missing.
> 
> I suggest to cut it down to 2 runs: 
> - IR verification enabled (i.e. -DVerifyIR=true, which is the default) 
> - IR verification disabled (i.e. -DVerifyIR=false)
> 
> In both runs we simultaneously set all property flags to some non-default value as a sanity test.
> 
> This reduces the test execution time from around 20-30s down to 3-4s.
> 
> Thanks,
> Christian

LGTM otherwise. Thanks @chhagedorn!

test/hotspot/jtreg/compiler/lib/ir_framework/README.md line 178:

> 176: - `-DWarmup=200`: Provide a new default value of the number of warm-up iterations (framework default is 2000). This might have an influence on the resulting IR and could lead to matching failures (the user can also set a fixed default warm-up value in a test with `testFrameworkObject.setDefaultWarmup(200)`).
> 177: - `-DReportStdout=true`: Print the standard output of the test VM.
> 178: - `-DVerbose=true`: Enable more fain-grained logging (slows the execution down).

Suggestion:

- `-DVerbose=true`: Enable more fine-grained logging (slows the execution down).


it just caught my eye 😉

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestDFlags.java line 23:

> 21:  * questions.
> 22:  */
> 23: 

I just noticed the copyright year

-------------

Marked as reviewed by dfenacci (Committer).

PR Review: https://git.openjdk.org/jdk/pull/27690#pullrequestreview-3315265256
PR Review Comment: https://git.openjdk.org/jdk/pull/27690#discussion_r2414163890
PR Review Comment: https://git.openjdk.org/jdk/pull/27690#discussion_r2414195124


More information about the hotspot-compiler-dev mailing list