RFR: 8347555: [REDO] C2: implement optimization for series of Add of unique value [v7]
    Kangcheng Xu 
    kxu at openjdk.org
       
    Fri Oct 10 19:24:20 UTC 2025
    
    
  
On Fri, 10 Oct 2025 19:05:26 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Many thanks to @eme64 and @rwestrel for reviewing. It was really educational!
>
> @tabjy Congrats on the integration!
> 
> This is not an official rule, but we consider it good practice not to integrate of Friday, and even less on Friday afternoon. If something breaks you probably would not be around on the weekend to fix it, and so it would mean we have more failing tests in the CI, and waste resources and have a polluted CI pipeline. It could then happen that someone just backs out your change, instead of giving you a few hours to fix a P1 bug. Again, not an official rule, just something we like to do ;)
@eme64 Thank you for letting me know! Sorry I wasn't aware of this practice. Thanks for explaining. It makes a lot sense and potentially save me troubles, too. I'll avoid integrating before weekends and holidays in the future. Again sorry about that. Hopefully nothing breaks!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23506#issuecomment-3391982918
    
    
More information about the hotspot-compiler-dev
mailing list