RFR: 8359412: Template-Framework Library: Operations and Expressions [v6]

Emanuel Peter epeter at openjdk.org
Mon Oct 13 08:38:08 UTC 2025


On Mon, 13 Oct 2025 08:02:40 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - more comments
>>  - add othervm to test
>
> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestPrimitiveTypes.java line 226:
> 
>> 224:             import java.util.Random;
>> 225:             import jdk.test.lib.Utils;
>> 226:             import compiler.lib.generators.*;
> 
> Could this be an utility method like `libraryRNGImports()` or something like that?

I suppose it could be. But I consider these imports so general that they are most likely already imported in all relevant cases. I propose that we keep it as is for now, and add the extra method if it becomes too cumbersome in the future to do it manually.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26885#discussion_r2425568551


More information about the hotspot-compiler-dev mailing list