RFR: 8366990: C2: Compilation hits the memory limit when verifying loop opts in Split-If code [v2]

[Benoît Maillard]

On Fri, 10 Oct 2025 14:59:50 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add -XX:+UnlockDiagnosticVMOptions
>
> src/hotspot/share/ci/ciInstanceKlass.cpp line 443:
> 
>> 441:       if (field_off == field_offset)
>> 442:         return field->layout_type();
>> 443:     }
> 
> Could this code be shared with `get_field_by_offset()`? We could put it into a method and return the field.
> 
> Not sure if it's also worth for the field descriptor below when having a "get field descriptor" method to further share code. You would need to check. Anyway, I'm fine with both :-)

Thanks for the suggestion, I just added a private `get_non_static_field_by_offset` method. I would have done the same for the field descriptor, but as it's not a pointer and there is no predefined default value it is not really practical.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27731#discussion_r2426061043