RFR: 8366990: C2: Compilation hits the memory limit when verifying loop opts in Split-If code [v2]

Benoît Maillard bmaillard at openjdk.org
Mon Oct 13 11:41:04 UTC 2025


On Sat, 11 Oct 2025 06:07:05 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add -XX:+UnlockDiagnosticVMOptions
>
> test/hotspot/jtreg/compiler/loopopts/TestVerifyLoopOptimizationsHitsMemLimit.java line 123:
> 
>> 121:     public static void main(String[] t) {
>> 122:         try {
>> 123:             test(t);
> 
> Suggestion:
> 
>             test(t);
>             throw new RuntimeException("The expected NPE do not seen");

Thanks for the suggestion. I would argue that this does not really add value, as this essentially boils down to checking that accessing an uninitialized reference throws a `NullPointerException`, which is not really what this test is about. I would rather keep it specific.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27731#discussion_r2426078675


More information about the hotspot-compiler-dev mailing list