RFR: 8366990: C2: Compilation hits the memory limit when verifying loop opts in Split-If code [v2]
    Emanuel Peter 
    epeter at openjdk.org
       
    Tue Oct 14 09:46:40 UTC 2025
    
    
  
On Mon, 13 Oct 2025 11:38:07 GMT, Benoît Maillard <bmaillard at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/loopopts/TestVerifyLoopOptimizationsHitsMemLimit.java line 123:
>> 
>>> 121:     public static void main(String[] t) {
>>> 122:         try {
>>> 123:             test(t);
>> 
>> Suggestion:
>> 
>>             test(t);
>>             throw new RuntimeException("The expected NPE do not seen");
>
> Thanks for the suggestion. I would argue that this does not really add value, as this essentially boils down to checking that accessing an uninitialized reference throws a `NullPointerException`, which is not really what this test is about. I would rather keep it specific.
@benoitmaillard Drive-by comment: if you can add it, I would. Almost all checks add value, even if they don't add value to exactly what you are testing right now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27731#discussion_r2428548329
    
    
More information about the hotspot-compiler-dev
mailing list