RFR: 8369444: JavaFrameAnchor on PPC64 has unnecessary barriers

Martin Doerr mdoerr at openjdk.org
Tue Oct 14 14:26:48 UTC 2025


On Mon, 13 Oct 2025 11:48:42 GMT, David Briemann <dbriemann at openjdk.org> wrote:

> No hardware barriers are necessary. All members are volatile and the profiler is run from a signal handler and only observers the thread its running on.

LGTM.

src/hotspot/cpu/ppc/javaFrameAnchor_ppc.hpp line 76:

> 74:   intptr_t* last_Java_fp() const      { return *(intptr_t**)_last_Java_sp; }
> 75: 
> 76:   void set_last_Java_sp(intptr_t* sp) {  _last_Java_sp = sp; }

Would be nice to remove 1 whitespace.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27768#pullrequestreview-3335984117
PR Review Comment: https://git.openjdk.org/jdk/pull/27768#discussion_r2429400259


More information about the hotspot-compiler-dev mailing list