RFR: 8369232: testlibrary_tests/ir_framework/tests/TestScenariosCrossProduct.java timed out [v3]

Christian Hagedorn chagedorn at openjdk.org
Tue Oct 14 17:09:49 UTC 2025


On Tue, 14 Oct 2025 15:43:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add simple end to end test + review comment
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestScenariosCrossProduct.java line 332:
> 
>> 330:             // Expected.
>> 331:             System.setErr(originalErr);
>> 332:             Asserts.assertTrue(e.getMessage().contains("The following scenarios have failed: #0, #1, #2, #3"));
> 
> Can you somehow check that there is nothing after the `#3`? Just to make sure we don't have a `#4` ;)
> 
> Optional if too much work.

Good catch! I can just match the `.` at the end :-) 

Pushed an update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27672#discussion_r2429874353


More information about the hotspot-compiler-dev mailing list